[FIX] Build hermes from source on PR against stable #34228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
fix/build_hermes_against_stable
branch
from
55ed302 to
a2d6f5a
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 20, 2022
Summary: This Diff is a copy of this [PR](facebook#34228) that we have against 0.69-stable. This Diff makes sure we can build Hermes also in PR that are created against a stable branch ## Changelog [General] [Changed] - Make sure we can build Hermes from source when PR are opened agains -stable Differential Revision: D37961092 fbshipit-source-id: f9f9c9a71fa39303ddb775c10f9ad3d3ea2843f2
Base commit: 143a0f7 |
facebook-github-bot
added
the
Shared with Meta
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
Summary: Pull Request resolved: #34224 This Diff is a copy of this [PR](#34228) that we have against 0.69-stable. This Diff makes sure we can build Hermes also in PR that are created against a stable branch ## Changelog [General] [Changed] - Make sure we can build Hermes from source when PR are opened agains -stable Reviewed By: cortinico Differential Revision: D37961092 fbshipit-source-id: 65577fcc69f0e2a68377cbd46e3bd3a6af24e7c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that we can build Hermes from source also when we are creating prs against stable branches.
It also revert the changes of #34223 because they did not fix the issue.
Changelog
[General] [Changed] - Make sure we can build Hermes from source when PR are opened agains
-stableTest Plan
Tested locally + CircleCI is green (a part from
test_ios_unit)